fix(scripts,objectql): codemod-split-engine --members reads hand-written facet headers and inverts its import edits; move registerApp, registerDriver and registerHook by objectstack-fleet[bot] · Pull Request #30716 · objectstack-ai/objectstack

objectstack-fleet · 2026-11-05T23:04:21Z

Requested by Elon · project thread

domain:devx#3 · os-elon-musk · session_016WV4cwSsWgu5WEWLNtFrf3

Fixes #30572
Refs #30054

Clause-②: no
Metadata-protocol: none

维护者速读

改了什么:scripts/codemod-split-engine.mjs --members 现在接受「模块头被手工续写过」的 facet 模块,并且在搬移改动了接收模块 import 块时,仍能逐字节证明撤销;随后用它把 registerApp、registerDriver、registerHook 三个方法体搬进各自的 facet,并删掉登记表里对应的三行例外。
为什么改:refactor: give the inferred-return-type public methods on the engine.ts and protocol.ts facades explicit return types (.d.ts unchanged), so the codemod can move their bodies #30054 的 PR refactor(objectql): spell the eight ObjectQL facade methods' inferred return types and move five bodies into their facets (.d.ts byte-equal) #30571 搬了五个方法体,这三个被 codemod 拒绝(engine-registration.ts 的模块头被手改过;registerHook 的撤销证明在 import 块处失败),只能留在类上当例外。
风险与回滚:纯搬移,运行时行为不变;@objectstack/objectql 构建出的三个 .d.ts 在搬移前后逐字节相同。撤销证明仍是逐字节比较,没有做任何空白或 import 归一化。回滚即 revert 本 PR。
先看:scripts/codemod-split-engine.mjs 的 headerNamesOf 与 importEditsOf;packages/objectql/src/engine-hooks-and-functions.ts 的 import 块。
两分钟验证:node scripts/codemod-split-engine.mjs --members --verify --base origin/main,预期最后一行写 "undoing the moves does rebuild the base engine.ts and its modules byte-for-byte",exit 0;node scripts/codemod-split-engine.mjs --self-test 预期 129 cases pass。
需要你做的:无,席位落地。

What changes

scripts/codemod-split-engine.mjs, fourth pass (--members), two shapes it used to refuse:
- A header a hand edit wrote on after. engine-registration.ts's header carries a sentence written by hand after the generated one (isExternalWriteForbidden was written there by hand). headerNamesOf now reads the words after the header sentence, in the same paragraph, as a tail, and accepts the header only when moduleHeaderLines(title, names, tail) rewraps to it byte for byte. The pass rewrites the sentence it owns (the list grows) and carries the tail over unedited; the undo rewraps the same tail. A tail that does not rewrap as the pass wraps it is still refused.
- An import edit the prune cannot take back. registerHook's parameter docblock links HookEntry, so the move adds HookEntry to the module's import type from ./engine-top-level.js. The base module already carried an unresolved {@link HookEntry.dispatchUnscopedMultiWrite} in a staying docblock; once the binding exists, that link resolves, so "prune what nothing reads" keeps it and the undo stopped one line short of the base. importEditsOf now reads the edits the move made off the base and head import blocks (bindings added, and bindings widened from type-only to value) and the undo inverts exactly those, then prunes as before. Each inverted edit is checked: a moved member's own text must read the name, and a head that dropped or narrowed a base binding fails, since no undo could restore it. The lines left are rendered as the first pass writes them, and the result is still compared with the base byte for byte.
The three moves, written by the codemod on the latest main: registerApp and registerDriver into engine-registration.ts, registerHook into engine-hooks-and-functions.ts. The stubs, facet members, host interfaces, host factories and imports are the pass's own output. engine.ts goes from 11,309 to 11,086 lines.
scripts/facade-delegation-registry.json: the three #30054 rows for these members are removed; check:facade-delegation-only is green with 53 named exceptions.
.changeset/30572-objectql-registration-bodies.md: @objectstack/objectql patch, following PR refactor(objectql): spell the eight ObjectQL facade methods' inferred return types and move five bodies into their facets (.d.ts byte-equal) #30571's changeset.

Tests

The codemod's self-test (node scripts/codemod-split-engine.mjs --self-test): 129 cases in 9 batteries pass. The fourth-pass battery gains five cases, and its pinned floor goes from 18 to 23:

a header a hand edit wrote on after is accepted: the list grows, the hand's words follow it unedited, and the moves prove;
a hand tail that does not rewrap as the pass wraps it refuses;
one edited character in the hand's words at head fails;
a base docblock link that a moved body's import comes to resolve: the undo drops the binding the move added, and the moves prove byte for byte;
a binding the head added that only a staying docblock links, and no moved member reads, fails.

Reverse verification (one-time, run on the committed fix, restored to the HEAD blob)

importEditsOf made to return no edits: case 4 goes red ("undoing the moves out of engine-lifecycle.ts does not rebuild its base (first difference at line 41)"), and --members registerHook on the real tree fails again at line 46 of engine-hooks-and-functions.ts, the card's refusal.
headerNamesOf made to accept no tail: the self-test stops at "engine-lifecycle.ts: its header is not as the first pass wrote it", and --members registerApp on the real tree refuses again with the card's message.
After each, git checkout HEAD -- scripts/codemod-split-engine.mjs and git status --porcelain empty.

Verification

Final head is the merge of origin/main a2437b56 (which edited registerApp's body in #30656) into this branch; the moves were regenerated on that main rather than text-merged.

Before (main f4d568ba): --members registerApp / registerDriver refused with "engine-registration.ts: its header is not as the first pass wrote it" (exit 2); --members registerHook failed the undo proof at line 46 of engine-hooks-and-functions.ts (exit 1; the card recorded line 44 on an older main).
After: node scripts/codemod-split-engine.mjs --members --verify --base a2437b560b exits 0: "3 moved method(s) (registerHook, registerApp, registerDriver); engine.ts 11309 -> 11086 lines; undoing the moves does rebuild the base engine.ts and its modules byte-for-byte once the 7 import binding(s) only moved bodies read are pruned from the base".
Public .d.ts for @objectstack/objectql: built at base a2437b56 and at head; dist/index.d.ts, dist/core.d.ts and dist/util-B0RqjNMv.d.ts are byte-equal (sha256 4d00ae43…, a0cdd71a…, 69f1c293… on both sides). Control: RegistrationFacet.registerApp occurs 0 times in the base dist/index.js and once in the head's, so each side's build is its own.
pnpm --filter @objectstack/objectql typecheck: exit 0 (including check:test-typecheck). pnpm --filter @objectstack/objectql test: 556 files, 11068 tests passed (lock VERDICT command-exit 0), at head 3e387e33.
node scripts/pm/dispatch-gates.mjs --commands: 73 families derived at head 3e387e33; 72 exit 0. pnpm check:dual-build-cjs-loads is NOT MEASURED locally (exit 3, PREREQUISITE NOT MET: it reads every package's dist/, and only the @objectstack/objectql closure was built here); CI runs it in Lint & Repo Gates. --ran: 73 derived, 72 run, 1 NOT-MEASURED, 0 UNRUN. The codemod's own self-test (above) is outside the derived set and was run separately.

Acceptance notes

The undo is no longer computed from the head alone for the import block: it reads the base's binding names to know which bindings the move added. That is the information the head cannot carry (two different bases give the same head when a staying docblock links a name a moved body imports). The comparison itself is unchanged, byte for byte, and every edit it inverts must be one a moved member's text reads.
Sibling codemod-split-protocol: add a pass that moves a member of the landed protocol.ts facade into its facet (it refuses its own output, and the split no longer re-proves from its #29985 base) #30518 edits scripts/codemod-split-protocol.mjs and other rows of scripts/facade-delegation-registry.json; this PR does not touch that codemod. Whichever lands second merges main.

Human Minimum

1. Schemas start as Zod; packages/spec holds no runtime logic. (Not touched.)
2. Every name I added uses the casing for its kind.
3. No formatter ran; pnpm lint is CI's run.
4. One issue, one branch off an up-to-date main, one pull request.
5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
6. packages/spec touched: its generated artifacts are regenerated and committed. (Not touched.)
7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
8. Title, body and comments are in English (the 维护者速读 block is the lane's maintainer summary).
The Before Submitting list in CONTRIBUTING.md is done.

Generated by Claude Code

…der tail and inverts the import edits a move made The fourth pass refused engine-registration.ts, whose header a hand edit wrote on after (isExternalWriteForbidden), and failed the undo proof of registerHook, whose import of HookEntry resolves a docblock link the base module left unresolved, so the prune could not take it back. headerNamesOf now reads the hand's words after the header sentence and accepts the header when the names and those words rewrap to it byte for byte; the pass carries them over. The undo inverts the import edits it reads off the base and head import blocks (bindings added or widened, each read by a moved member; none dropped or narrowed) instead of relying on the prune alone. The comparison stays byte for byte. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cwSsWgu5WEWLNtFrf3

… onto their facets Written by scripts/codemod-split-engine.mjs --members (the undo proof passes byte for byte); their three facade-delegation-registry exceptions are dropped, so check-facade-delegation-only holds them as delegations. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cwSsWgu5WEWLNtFrf3

Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cwSsWgu5WEWLNtFrf3

…-wuvbn6 # Conflicts: # packages/objectql/src/engine.ts

github-actions · 2026-11-05T23:05:37Z

📓 Docs Drift Check

This PR changes 2 package(s): @objectstack/objectql, @objectstack/spec, touching 19 documentable anchor(s). ⚠️ 1 changed file(s) yielded no anchor (packages/spec/liveness/manifest.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

content/docs/kernel/events.mdx (via registerHook (symbol, a method of class HooksAndFunctionsFacet; a method of class ObjectQL))
content/docs/plugins/development.mdx (via registerHook (symbol, a method of class HooksAndFunctionsFacet; a method of class ObjectQL))
content/docs/protocol/kernel/error-handling.mdx (via registerApp (symbol, a method of class ObjectQL; a method of class RegistrationFacet))

⛔ 2 release-owned page(s) also name something this change touched. These are read-only:

content/docs/releases/v16.mdx (via registerHook (symbol, a method of class HooksAndFunctionsFacet; a method of class ObjectQL))
content/docs/releases/v17/17-5.mdx (via registerHook (symbol, a method of class HooksAndFunctionsFacet; a method of class ObjectQL))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see

1 changed file(s) yielded no anchor (packages/spec/liveness/manifest.json) — pages documenting those are invisible to this run
1 name(s) were too generic to anchor anything (single lowercase words)
the SDK route bridge reached 63 of 221 client-bound route-ledger rows — the other 158 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 158: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 103 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 172 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 3da9a4c132db7bf5ae1ca673930c1034e50d0195 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 6a8c96726dcd9b7d55c89465fb49ee15c9a00d9d — the merge of head 81d1ccf051ce8042a90ea7781d03a1af1ba8b95b into base 3da9a4c132db7bf5ae1ca673930c1034e50d0195, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 6a8c96726dcd9b7d55c89465fb49ee15c9a00d9d && git checkout 6a8c96726dcd9b7d55c89465fb49ee15c9a00d9d
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 3da9a4c132db7bf5ae1ca673930c1034e50d0195 81d1ccf051ce8042a90ea7781d03a1af1ba8b95b && git checkout -B drift-repro 3da9a4c132db7bf5ae1ca673930c1034e50d0195 && git merge --no-ff 81d1ccf051ce8042a90ea7781d03a1af1ba8b95b

node scripts/docs-audit/affected-docs.mjs --json 3da9a4c132db7bf5ae1ca673930c1034e50d0195

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 3da9a4c132db7bf5ae1ca673930c1034e50d0195 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

objectstack-fleet · 2026-11-05T23:35:10Z

domain:devx#3 · os-elon-musk · session_016WV4cz3RTQjLh7hZBLzgtZ

席位核对 · ACCEPT · `3e387e33` · 2026-11-05T23:34Z

Head-sha: 3e387e336fdf267b29ec5e9876db6423516a0a98

Shape: 6 files, +461/−302 (763 < 3,000), all on the claim surface (the engine codemod, engine.ts, engine-registration.ts, engine-hooks-and-functions.ts, the registry, one changeset). Not governed. Fixes #30572, Refs #30054, Clause-②: no, Metadata-protocol: none at line start.
Premise measured: both refusals the card records were reproduced on main before the change (dev report 6671852032); main moved under the dev (fix(objectql): a package registered again lists its navigation contributions once, not once more per registration #30656 edited registerApp), and the moves were regenerated on it, --members --verify --base a2437b560b exit 0.
The card's bar ("without weakening the byte-for-byte undo proof"): met as described in the report: the header case accepts a hand-written tail only when names plus tail rewrap to the header byte for byte; the import-block case reads the edits off the base and head import blocks, requires each to be read by a moved member's own text, fails on any dropped or narrowed base binding, and inverts exactly those in the undo. The final comparison stays byte for byte, no normalisation.
Gates: check-runs on this head read by the seat: 35 success, 13 skipped, 0 failed or pending. Dev: public .d.ts byte-equal (3 files), objectql typecheck 0, 556 files / 11,068 tests passed, dispatch-gates 72 of 73 exit 0, 1 NOT-MEASURED (whole-tree CJS build, covered by CI's build).
Spot checks: the three engine.ts members are one-line .call(host.of(this), …) delegations to RegistrationFacet / HooksAndFunctionsFacet; the registry drops exactly the three rows registerApp, registerDriver, registerHook.
Changeset: '@objectstack/objectql': patch (source moved inside a published package, as refactor(objectql): spell the eight ObjectQL facade methods' inferred return types and move five bodies into their facets (.d.ts byte-equal) #30571).
Out of scope: none. refactor: give the inferred-return-type public methods on the engine.ts and protocol.ts facades explicit return types (.d.ts unchanged), so the codemod can move their bodies #30054 still waits on codemod-split-protocol: add a pass that moves a member of the landed protocol.ts facade into its facet (it refuses its own output, and the split no longer re-proves from its #29985 base) #30518's second PR.
Landing: non-governed; flips when the maintainer's landing word for this term is on record.

objectstack-fleet · 2026-11-06T04:17:20Z

domain:devx#3 · os-elon-musk · session_016WV4cz3RTQjLh7hZBLzgtZ

Queue triage · pulled from the merge queue · 2026-11-06T04:16Z

Signature: Test Core (1/8), @objectstack/spec scripts/liveness/check-liveness.test.ts, about 20 cases, one cause: 1 UNANCHORED: manifest/contributes.kinds → packages/objectql/src/engine.ts. Read on merge-queue run 42159595597 (test(qa-scenarios): add the leave_balances mid-tier scenario card #30690's group, base 198d1125 = this PR's queue commit).
Cause: this PR moves the contributes.kinds read with registerApp into engine-registration.ts; the path citation in packages/spec/src/kernel/manifest.zod.ts (docblock near line 789) still names engine.ts. main stays green because the read is still in engine.ts there. Not a flake; not caused by the PRs queued behind it.
Action: converted to draft at 04:16Z (out of the queue), ACCEPT 6672344011 withdrawn for this head. Rework: repoint the anchor in this PR (ruling 6597555122 item 3, by-path readers move with the code), run the liveness check, new head → seat delta review → re-land.

… where registerApp's reads moved check-liveness reds on manifest/contributes.kinds once registerApp's body leaves engine.ts: the cited file no longer names the key. The seven rows citing engine.ts#registerApp are repointed (registerPackageBody for objects) with a dated note sentence each, and the changeset gains a spec patch. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cwSsWgu5WEWLNtFrf3

…-wuvbn6

github-actions · 2026-11-06T04:24:04Z

⛔ merge queue 构建失败 — 先分诊，再决定要不要重排

队列构建 42159593224 红了。队列跑的是全量套件（PR 侧 CI 只跑 affected 子集），
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

分类：failure —— 按下面的日志分诊。

失败的 job（日志抽取，best effort）：

Test Core (2/8) — 失败步骤: Run this shard's tests

@objectstack/spec:test:      ✓ inverts the card's measured control: the three bogus keys now FAIL parse instead of adding zero warnings  320ms
  ↳ 失败原因: (这条 FAIL 之后 12 行内没有可识别的原因行 —— 点进 job 看)
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > is green against a verbatim copy of the shipped ledgers
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > stays green when the missing path is attributed to ANOTHER repo
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > never bounds a citation attributed to ANOTHER repo
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > prints the citation count and how many are in range, in the documented two
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — symbol anchors (#12516) > stays GREEN on the drifted BEFORE-state — the honest residual this grammar e
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — symbol anchors (#12516) > prints the anchor count and how many resolve, equal on a green run
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the evidence-scan population (#13041) > stays GREEN when a `dead` entry carries the SAME rotted pointe
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the evidence-scan population (#13041) > declares every status either scanned or explicitly unscanned, 
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the live-elsewhere criteria (#13483) > is green on the shipped ledgers and publishes the population be
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the live-elsewhere criteria (#13483) > is green on a planted live-elsewhere row and counts it as carry
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the README state table (#7257) > is green against a verbatim copy, and says how many rows it checked
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,

↳ 失败原因 是判读的关键：超时（Test timed out in … / Hook timed out in …）多半是负载/时序，不是本 PR 的回归；
断言（AssertionError: …）才指向真实的行为改变。两者的 FAIL 行长得一模一样，只有这一行能区分。

⚠️ 断言这一侧有一类例外，判据是断言在测什么，不是它是不是 AssertionError。 断言的对象是产品行为（一个值、一个形状、一次拒收）⇒ 照上面读：真实的行为改变，去查，⛔ 不要重排掉；
断言的对象是这次实验自身的有效性前提（跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件）⇒ 它跟超时是同一类，同样对负载敏感，重排一次是合法的判别手段。
识别是机械的：断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为（真回归）；
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提：它守护的那条不变式当时是绿的，同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量，仍然是时间测量。（⛔ 这只改「怎么读一次红」，不改「哪些测试可以重排」——后者由别处管。）

跨 PR 相同签名（24h，按失败测试文件聚合）：

scripts/liveness/check-liveness.test.ts — 24h 内已弹出 4 个 PR（test(qa-scenarios): add the leave_balances mid-tier scenario card #30690、test(qa-scenarios): add the asset_lifecycle mid-tier scenario card #30695、test(qa-scenarios): add the order_to_cash mid-tier scenario card #30706、fix(scripts,objectql): codemod-split-engine --members reads hand-written facet headers and inverts its import edits; move registerApp, registerDriver and registerHook #30716），但它们同属 1 条投机栈 ⇒ 1 次独立命中。⚠️ 同签名的汇总 issue Queue-flake anchor: scripts/liveness/check-liveness.test.ts #30374 已作为重复关闭，且没有仍然打开的同签名汇总 issue ⇒ 本次不新建（新建只会再被判重）。请到它指向的那张 issue 上谈，或重开 Queue-flake anchor: scripts/liveness/check-liveness.test.ts #30374。
⚠️ 24h 评论账本没读完（超过 5 页仍未读到窗口尽头），所以上面的「不同 PR 数」是下界，不是全量。

历史信号：

本 PR 过去 24h 无队列失败记录（首次）。
过去 24h 队列共有 6 个失败构建（不含本次）。

分诊清单：

失败测试在本 PR 改动的包里 → 真回归，修 PR。
失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」；已有汇总 issue ⇒ flaky/环境问题实锤，去那张 issue 上谈，修好前重排只会再烧一轮全队列。
两者都不是 → 可能与同组 PR 语义冲突；等前面的 PR 落地或失败出队后再重排一次即可，不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

github-actions · 2026-11-06T04:41:28Z

⛔ merge queue 构建失败 — 先分诊，再决定要不要重排

队列构建 42161968276 红了。队列跑的是全量套件（PR 侧 CI 只跑 affected 子集），
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

分类：failure —— 按下面的日志分诊。

失败的 job（日志抽取，best effort）：

Test Core (2/8) — 失败步骤: Run this shard's tests

@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > is green against a verbatim copy of the shipped ledgers
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > stays green when the missing path is attributed to ANOTHER repo
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > never bounds a citation attributed to ANOTHER repo
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — evidence pointers (#5623) > prints the citation count and how many are in range, in the documented two
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — symbol anchors (#12516) > stays GREEN on the drifted BEFORE-state — the honest residual this grammar e
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — symbol anchors (#12516) > prints the anchor count and how many resolve, equal on a green run
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the evidence-scan population (#13041) > stays GREEN when a `dead` entry carries the SAME rotted pointe
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the evidence-scan population (#13041) > declares every status either scanned or explicitly unscanned, 
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the live-elsewhere criteria (#13483) > is green on the shipped ledgers and publishes the population be
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the live-elsewhere criteria (#13483) > is green on a planted live-elsewhere row and counts it as carry
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the README state table (#7257) > is green against a verbatim copy, and says how many rows it checked
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,
@objectstack/spec:test:  FAIL   local  scripts/liveness/check-liveness.test.ts > check:liveness — the generated count artifact (#7377, sharded #20361) > is green against a verbatim copy, says the shar
  ↳ 失败原因: @objectstack/spec:test: AssertionError: Spec liveness gate (registry-rooted) — governed types: object, field, flow, action, hook, permission, position, agent, tool, skill, dataset, page, view, report,

↳ 失败原因 是判读的关键：超时（Test timed out in … / Hook timed out in …）多半是负载/时序，不是本 PR 的回归；
断言（AssertionError: …）才指向真实的行为改变。两者的 FAIL 行长得一模一样，只有这一行能区分。

⚠️ 断言这一侧有一类例外，判据是断言在测什么，不是它是不是 AssertionError。 断言的对象是产品行为（一个值、一个形状、一次拒收）⇒ 照上面读：真实的行为改变，去查，⛔ 不要重排掉；
断言的对象是这次实验自身的有效性前提（跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件）⇒ 它跟超时是同一类，同样对负载敏感，重排一次是合法的判别手段。
识别是机械的：断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为（真回归）；
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提：它守护的那条不变式当时是绿的，同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量，仍然是时间测量。（⛔ 这只改「怎么读一次红」，不改「哪些测试可以重排」——后者由别处管。）

跨 PR 相同签名（24h，按失败测试文件聚合）：

scripts/liveness/check-liveness.test.ts — 24h 内已弹出 5 个 PR（test(qa-scenarios): add the leave_balances mid-tier scenario card #30690、test(qa-scenarios): add the asset_lifecycle mid-tier scenario card #30695、test(qa-scenarios): add the order_to_cash mid-tier scenario card #30706、fix(scripts,objectql): codemod-split-engine --members reads hand-written facet headers and inverts its import edits; move registerApp, registerDriver and registerHook #30716、fix(scenarios): make the crm control card agree with its own personas #30801），但它们同属 1 条投机栈 ⇒ 1 次独立命中。⚠️ 同签名的汇总 issue Queue-flake anchor: scripts/liveness/check-liveness.test.ts #30374 已作为重复关闭，且没有仍然打开的同签名汇总 issue ⇒ 本次不新建（新建只会再被判重）。请到它指向的那张 issue 上谈，或重开 Queue-flake anchor: scripts/liveness/check-liveness.test.ts #30374。
⚠️ 24h 评论账本没读完（超过 5 页仍未读到窗口尽头），所以上面的「不同 PR 数」是下界，不是全量。

历史信号：

⚠️ 本 PR 过去 24h 已在队列失败 1 次（不含本次）。 内容未变而反复失败 ⇒ 高度怀疑 flaky 测试或与同组 PR 的语义冲突，重排不解决。
过去 24h 队列共有 11 个失败构建（不含本次）。

分诊清单：

失败测试在本 PR 改动的包里 → 真回归，修 PR。
失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」；已有汇总 issue ⇒ flaky/环境问题实锤，去那张 issue 上谈，修好前重排只会再烧一轮全队列。
两者都不是 → 可能与同组 PR 语义冲突；等前面的 PR 落地或失败出队后再重排一次即可，不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

objectstack-fleet · 2026-11-06T05:19:49Z

domain:devx#3 · os-elon-musk · session_016WV4cz3RTQjLh7hZBLzgtZ

席位核对 · re-ACCEPT (delta) · `81d1ccf0` · 2026-11-06T05:19Z

Head-sha: 81d1ccf051ce8042a90ea7781d03a1af1ba8b95b

Delta since ACCEPT 6672344011 on 3e387e33: one fix commit plus a clean merge of main 100303c0 (touches none of this PR's files). The fix repoints seven rows of packages/spec/liveness/manifest.json from engine.ts#registerApp to engine-registration.ts#registerApp (objects to #registerPackageBody, where that read sits), each with a dated note; the changeset gains '@objectstack/spec': patch (the ledger ships in spec's files). This answers queue triage 6676744620.
Shape: 7 files, +477/−316 (793 < 3,000). check-governed-merges --pr 30716: NOT governed. mergeable_state clean.
Gates: check-runs on this head read by the seat: 55 success, 9 skipped, 0 failed or pending, including the two jobs the queue failed on (spec property liveness, Test Core). Dev: check:liveness exit 0, check-liveness.test.ts 74/74, --members --verify --base origin/main exit 0, dispatch-gates 79 of 80 exit 0, 1 NOT-MEASURED (whole-tree CJS build, CI's).
Acceptance notes (out of scope, both still resolve, no gate red): docs/qa/platform-checklist/areas/platform-core.json still cites engine.ts#registerApp for the objectExtensions loop, now in engine-registration.ts; the liveness row for navigationContributions.app still says registerApp "hands each entry to the registry", which fix(objectql): a package registered again lists its navigation contributions once, not once more per registration #30656 changed to setPackageNavContributions when there is an id. Carried to the devx lane's next touch of either file.
Landing: non-governed; re-landing now under the maintainer's instruction to review and land per pm-dispatch (2026-11-06T03:51Z).

claude added 4 commits November 5, 2026 21:44

chore(changeset): objectql registration bodies move into their facets

08d0047

Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cwSsWgu5WEWLNtFrf3

Merge remote-tracking branch 'origin/main' into claude/project-thread…

3e387e3

…-wuvbn6 # Conflicts: # packages/objectql/src/engine.ts

github-actions Bot added size/l documentation Improvements or additions to documentation tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface labels Nov 5, 2026

objectstack-fleet Bot marked this pull request as ready for review November 6, 2026 03:53

objectstack-fleet Bot enabled auto-merge November 6, 2026 03:53

objectstack-fleet Bot added this pull request to the merge queue Nov 6, 2026

objectstack-fleet Bot assigned os-elon-musk Nov 6, 2026

objectstack-fleet Bot mentioned this pull request Nov 6, 2026

[Decision] PR assignee: an open PR names its owner — assign it to the claiming seat's account at pr_create (os-dev.md L38/L62 and execution-duties.md L67 forbid it today)? #29828

Closed

objectstack-fleet Bot marked this pull request as draft November 6, 2026 04:16

claude added 2 commits November 6, 2026 04:22

Merge remote-tracking branch 'origin/main' into claude/project-thread…

81d1ccf

…-wuvbn6

This was referenced Nov 6, 2026

test(qa-scenarios): add the asset_lifecycle mid-tier scenario card #30695

Merged

test(qa-scenarios): add the order_to_cash mid-tier scenario card #30706

Merged

This was referenced Nov 6, 2026

test(qa-scenarios): add the leave_balances mid-tier scenario card #30690

Merged

fix(scenarios): make the crm control card agree with its own personas #30801

Merged

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 6, 2026

objectstack-fleet Bot mentioned this pull request Nov 6, 2026

feat(scripts): codemod-split-protocol --members moves a member of the landed protocol.ts facade, and moves six #30054 door bodies #30687

Merged

9 tasks done

This was referenced Nov 6, 2026

feat(rest)!: serve ?names= on the /meta/:type list and close its query set #30709

Merged

feat(objectql,platform-objects): keep a by-id delete's rows in the recycle bin (ADR-0148) #30780

Merged

objectstack-fleet Bot marked this pull request as ready for review November 6, 2026 05:20

objectstack-fleet Bot enabled auto-merge November 6, 2026 05:20

objectstack-fleet Bot added this pull request to the merge queue Nov 6, 2026

Merged via the queue into main with commit a59d00a Nov 6, 2026
65 checks passed

objectstack-fleet Bot deleted the claude/project-thread-wuvbn6 branch November 6, 2026 05:50

Navigation Menu

Repository navigation

fix(scripts,objectql): codemod-split-engine --members reads hand-written facet headers and inverts its import edits; move registerApp, registerDriver and registerHook - #30716

fix(scripts,objectql): codemod-split-engine --members reads hand-written facet headers and inverts its import edits; move registerApp, registerDriver and registerHook#30716
objectstack-fleet[bot] merged 6 commits into
mainfrom
claude/project-thread-wuvbn6

objectstack-fleet Bot commented Nov 5, 2026

Uh oh!

github-actions Bot commented Nov 5, 2026 •

edited

Loading

Uh oh!

objectstack-fleet Bot commented Nov 5, 2026

Uh oh!

objectstack-fleet Bot commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

github-actions Bot commented Nov 6, 2026

Uh oh!

Uh oh!

objectstack-fleet Bot commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Nov 5, 2026

维护者速读

What changes

Tests

Verification

Acceptance notes

Human Minimum

Uh oh!

github-actions Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📓 Docs Drift Check

Uh oh!

objectstack-fleet Bot commented Nov 5, 2026

席位核对 · ACCEPT · 3e387e33 · 2026-11-05T23:34Z

Uh oh!

objectstack-fleet Bot commented Nov 6, 2026

Queue triage · pulled from the merge queue · 2026-11-06T04:16Z

Uh oh!

github-actions Bot commented Nov 6, 2026

⛔ merge queue 构建失败 — 先分诊，再决定要不要重排

Uh oh!

github-actions Bot commented Nov 6, 2026

⛔ merge queue 构建失败 — 先分诊，再决定要不要重排

Uh oh!

Uh oh!

objectstack-fleet Bot commented Nov 6, 2026

席位核对 · re-ACCEPT (delta) · 81d1ccf0 · 2026-11-06T05:19Z

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Nov 5, 2026 •

edited

Loading

席位核对 · ACCEPT · `3e387e33` · 2026-11-05T23:34Z

席位核对 · re-ACCEPT (delta) · `81d1ccf0` · 2026-11-06T05:19Z